Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for summary files beyond year 2262 #238

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Add support for summary files beyond year 2262 #238

merged 2 commits into from
Dec 9, 2023

Conversation

berland
Copy link
Collaborator

@berland berland commented Dec 7, 2023

Copied fallback code from res2df. Since #182 is stale, we duplicate the code from there.

Solves equinor/semeio#474

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (392218d) 83.31% compared to head (f406f34) 83.49%.

❗ Current head f406f34 differs from pull request most recent head 7230f4e. Consider uploading reports for the commit 7230f4e to get more accurate results

Files Patch % Lines
src/fmu/ensemble/util/dates.py 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   83.31%   83.49%   +0.17%     
==========================================
  Files          14       14              
  Lines        3026     3071      +45     
==========================================
+ Hits         2521     2564      +43     
- Misses        505      507       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copied fallback code from res2df
Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@berland berland merged commit 364ceb3 into master Dec 9, 2023
4 checks passed
@berland berland deleted the year2262 branch December 9, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants